Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label indicating the current selected value won't change when props change #34

Closed
begoat opened this issue Jun 12, 2018 · 11 comments
Closed

Comments

@begoat
Copy link

begoat commented Jun 12, 2018

I met some problems when try to change state after component mounted.

@lfkwtz
Copy link
Collaborator

lfkwtz commented Jun 12, 2018

Can you try with the the version currently on master and see if that fixes it? This sounds exactly like the bug fix I merged in yesterday.

#33

@begoat
Copy link
Author

begoat commented Jun 12, 2018

I am afraid it is still not working with version 3.1.1

@lfkwtz
Copy link
Collaborator

lfkwtz commented Jun 12, 2018

Version isn't what's important. Are you pulling the repo from master or from npm?

@begoat
Copy link
Author

begoat commented Jun 12, 2018

i pulled from npm just now, i will try the former one.

@begoat
Copy link
Author

begoat commented Jun 12, 2018

i clone this repo and install the npm dependency from file but it doesn't work

@lfkwtz
Copy link
Collaborator

lfkwtz commented Jun 12, 2018

try 3.1.2

@begoat
Copy link
Author

begoat commented Jun 13, 2018

lastest master branch doesn't solve the problem

@lfkwtz
Copy link
Collaborator

lfkwtz commented Jun 13, 2018

Your expo snack example changes the selected value state, and the picker label changes. I’m not understanding what is wrong with that example.

@begoat
Copy link
Author

begoat commented Jun 13, 2018

Sorry for the confusing problem description. I mean when run it in expo online the component works well, but when i use it in my repo, the label won't change, i don't know why so i issue it.

@lfkwtz
Copy link
Collaborator

lfkwtz commented Jun 30, 2018

You need to be using v2 or earlier. See the readme.

@lfkwtz lfkwtz closed this as completed Jun 30, 2018
@begoat
Copy link
Author

begoat commented Jun 30, 2018

Thank you, I tried and it worked. Sorry for not reading README carefully:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants