Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimisations - Fail early in appropriate matchers #8

Closed
lawrencelomax opened this issue Dec 10, 2013 · 1 comment
Closed

Optimisations - Fail early in appropriate matchers #8

lawrencelomax opened this issue Dec 10, 2013 · 1 comment
Assignees

Comments

@lawrencelomax
Copy link
Owner

In matchers for next values we can fail early

For example with haveIdenticalValues() for two signals:
1, 2, 3, 4, 5
1, 2, 5, 4, 5

we can fail when the events are known to be non-identical, i.e at index 2 of the values

@ghost ghost assigned lawrencelomax Dec 10, 2013
@lawrencelomax
Copy link
Owner Author

Matchers should be stricter by default. Unit Tests should make assertions about the exact values a Signal will contain, as non-determinism is not a desirable trait of tests. This may be relevant to async matchers, but synchronous matching is based on the actual Signal having completed before the matcher even returns success or failure.

Closing as I can't see this being that important right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant