Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word wrap problems (1.50.6) #421

Closed
2 tasks done
HellbringerOnline opened this issue Nov 9, 2022 · 3 comments · Fixed by #424
Closed
2 tasks done

Word wrap problems (1.50.6) #421

HellbringerOnline opened this issue Nov 9, 2022 · 3 comments · Fixed by #424
Labels
bug Something isn't working

Comments

@HellbringerOnline
Copy link

Checklist

Describe your issue here

Twitch
image

TwitchDownloader
image

@HellbringerOnline HellbringerOnline added the bug Something isn't working label Nov 9, 2022
@ScrubN
Copy link
Collaborator

ScrubN commented Nov 12, 2022

I fixed this, however I wanted to ask if you care that it always splits at the end of the line rather than splitting at a ? for URLs because that would require a slight rework

Also it currently does not respect right to left languages because it was getting pretty confusing to deal with both at the same time. Will probably modify to support RTL later

@HellbringerOnline
Copy link
Author

I fixed this, however I wanted to ask if you care that it always splits at the end of the line rather than splitting at a ? for URLs because that would require a slight rework

Also it currently does not respect right to left languages because it was getting pretty confusing to deal with both at the same time. Will probably modify to support RTL later

I think twitch adds a line break after the question mark if it's in a link, otherwise it adds a line break near the edge of the screen. Personally, I adhere to the idea that the render should be as similar as possible to the original chat

@ScrubN
Copy link
Collaborator

ScrubN commented Nov 12, 2022

I've added ? detection to wrap around. Twitch uses a link detection that must trigger before messages wrap at ?s so non-link ??? spam messages with no spaces don't look weird but I don't want make a URL detector. This is a good enough compromise for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants