Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR: Value cannot be null. (Parameter 'collection') #622

Closed
2 tasks done
Czompi opened this issue Mar 19, 2023 · 8 comments · Fixed by #623
Closed
2 tasks done

ERROR: Value cannot be null. (Parameter 'collection') #622

Czompi opened this issue Mar 19, 2023 · 8 comments · Fixed by #623
Labels
bug Something isn't working

Comments

@Czompi
Copy link
Contributor

Czompi commented Mar 19, 2023

Checklist

Edition

Windows GUI Application

Describe your issue here

When I try to download chat with images embedded, it gives the following error: ERROR: Value cannot be null. (Parameter 'collection')
It was not present in the previous versions.

Potential fix

I debugged a bit and found out that bttvChannel.channelEmotes can be null and there's no null check when we try to add it to BTTV emotes.

Affected version: 1.52.2

@Czompi Czompi added the bug Something isn't working label Mar 19, 2023
@ScrubN
Copy link
Collaborator

ScrubN commented Mar 19, 2023

Can you provide the video id? It's likely the API response is different from what we're normally expecting, which would be why it deserialized as null

@ScrubN
Copy link
Collaborator

ScrubN commented Mar 19, 2023

One of my test channels was able to trigger the error, which was exactly what I suspected. I'll release a hotfix in a day or two

@KINGMADMATTY
Copy link

i have the same error, i find github a little confusing. Has there been a fix to the error. If so what do i have to do to get it working.
Thanks for your time
Matt

@Czompi
Copy link
Contributor Author

Czompi commented Mar 23, 2023

ScrubN fixed it a few days ago.
It will work fine in the next release.
You can use the previous version, because that is not affected.

@KINGMADMATTY
Copy link

thanks ill try that
Matt

@KINGMADMATTY
Copy link

cool, dowloaded, installed it working thanks a million

@nguyend24
Copy link

I ran into this issue last week and I've been following it since. Not sure if what I'm seeing now should be a new issue or not. It's a slightly different error from before.

Happens when using the latest version of Ganymede, but rendering outside ganymede with v1.52.3 works. Mentioned it in Zibbp/ganymede#153, and referred here by @Zibbp but I'm not sure on which side the error lies since it renders fine on the CLI.

Here's a vod where this occurs.

https://www.twitch.tv/videos/1652395872

And this is the JSON for the chat. Changed the extension to txt so it would upload.
1652395872_fb1e4c92-bb1a-11ed-b463-0242ac130002-chat.txt

This is for chatrender.

[STATUS] - Fetching Images [1/2]
[LOG] - No valid typefaces were found for some messages.

[STATUS] - Rendering Video: 0% (0h0m12s Elapsed | 2h31m10s Remaining)Unhandled exception. System.AggregateException: One or more errors occurred. (Value cannot be null. (Parameter 'asset'))

@ScrubN
Copy link
Collaborator

ScrubN commented Apr 5, 2023

I ran into this issue last week and I've been following it since. Not sure if what I'm seeing now should be a new issue or not. It's a slightly different error from before.

Happens when using the latest version of Ganymede, but rendering outside ganymede with v1.52.3 works. Mentioned it in Zibbp/ganymede#153, and referred here by @Zibbp but I'm not sure on which side the error lies since it renders fine on the CLI.

Here's a vod where this occurs.

https://www.twitch.tv/videos/1652395872

And this is the JSON for the chat. Changed the extension to txt so it would upload. 1652395872_fb1e4c92-bb1a-11ed-b463-0242ac130002-chat.txt

This is for chatrender.

[STATUS] - Fetching Images [1/2] [LOG] - No valid typefaces were found for some messages.

[STATUS] - Rendering Video: 0% (0h0m12s Elapsed | 2h31m10s Remaining)Unhandled exception. System.AggregateException: One or more errors occurred. (Value cannot be null. (Parameter 'asset'))

This sounds like a new issue. If you can post the whole stacktrack, that would help significantly since I am unable to reproduce with the provided chat json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants