Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Highlight] Vertical slider: before and after #5084

Closed
leecalcote opened this issue Oct 27, 2023 · 17 comments
Closed

[Feature Highlight] Vertical slider: before and after #5084

leecalcote opened this issue Oct 27, 2023 · 17 comments
Assignees
Labels
framework/gatsby Gatsby related help wanted Extra attention is needed kind/enhancement New feature or request language/css language/html Issues or pull requests that use HTML

Comments

@leecalcote
Copy link
Member

_written up by from @MUzairS15 _

Current State of the Meshery.io site

Screenshot 2023-10-26 at 9 54 36 PM

The screenshot and text doesn't describe the capability of Meshery Extension to its fullest.

Desired State of the Meshery.io site

Add a vertical slider instead of the current screenshot. The left hand side of the slider would contain a K8s manifest for a multi-tier application.
The right side of the slider would contain the simplified view of the manifest i.e. Screenshot of manifest rendered on canvas.

If the contributor working on this issue, cannot find a screenshot/YAML to display, please atleast proceed with implementing the slider, leaving the screenshot/YAML as a placeholder.


Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

@leecalcote leecalcote added kind/enhancement New feature or request help wanted Extra attention is needed language/html Issues or pull requests that use HTML framework/gatsby Gatsby related language/css labels Oct 27, 2023
@aman44444
Copy link

@leecalcote i want to work on this feature can you please assign this to me?

@aman44444
Copy link

@leecalcote could you please provide me a reference to a vertical slider and explain this feature in more detail? I'd like to understand what it should look like

@theavitw
Copy link

theavitw commented Nov 1, 2023

Is this issue resolved ? "ok" : "I would like to work on it"

@MUzairS15
Copy link
Contributor

@aman44444 DO you have any updates?

@MUzairS15
Copy link
Contributor

MUzairS15 commented Nov 1, 2023

@aman44444 Do you want to know what a vertical slider is? (Google it).
In the two portions of the slider, one portion would have YAML content the other part would have an image.
First part

apiVersion: apps/v1
kind: Deployment
metadata: 
  name: backend
spec:
  selector:
    matchLabels:
      app: server
      tier: backend
  replicas: 1
  template:
    metadata:
      labels:
        app: server
        tier: backend
    spec: 
      containers:
        - name: server
          image: nginx
            - name: http
              containerPort: 80
---
....
----

Second part
MeshMap-Wed Nov 01 2023_12_10_06

@leecalcote
Copy link
Member Author

@theavitw, yes, please do give this ago as well. I'm not sure if @aman44444 is still working through this or not...

@aman44444
Copy link

@MUzairS15 how is this?
Screenshot (14)

@leecalcote
Copy link
Member Author

@theavitw
Copy link

theavitw commented Nov 5, 2023

https://reactscript.com/react-vertical-carousel/ something like this ?? @MUzairS15

@MUzairS15
Copy link
Contributor

Not a carousel, but a slider. Similar to what Lee pointed out.

@aman44444
Copy link

is it ok?
Screenshot (15)

@MUzairS15
Copy link
Contributor

Can you screenshot an live example instead of random text?

@aman44444
Copy link

here it is

Meshery.The.Kubernetes.and.Cloud.Native.Manager.-.an.extensible.developer.platform._.Meshery.Mozilla.Firefox.2023-11-14.16-31-00.-.Trim.-.Trim.mp4

@abhijeetgauravm
Copy link
Contributor

Hey @aman44444 Let's discuss this on website call today at 6:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.

@leecalcote
Copy link
Member Author

leecalcote commented Nov 20, 2023

@aman44444 do you have an open PR? Let's go! This is what we're looking for (without the hideous blue color).

@abhijeetgauravm
Copy link
Contributor

@aman44444 do you have an open PR? Let's go! This is what we're looking for (without the hideous blue color).

// @aman44444

@abhijeetgauravm
Copy link
Contributor

Closing this as implemented by another contributor. Let's go ahead and get you onto a new issue. Thanks for your efforts here, @aman44444.
Here you'll find many good-first and help-wanted issues:
https://github.com/issues?q=is%3Aopen+is%3Aissue+archived%3Afalse+org%3Alayer5io+org%3Ameshery+org%3Aservice-mesh-performance+org%3Aservice-mesh-patterns+label%3A%22help+wanted%22+

Feel free to check these out and comment to get assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework/gatsby Gatsby related help wanted Extra attention is needed kind/enhancement New feature or request language/css language/html Issues or pull requests that use HTML
Development

No branches or pull requests

5 participants