Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Image Carousel] Investigate issues with aspect ratio #5156

Closed
leecalcote opened this issue Nov 27, 2023 · 3 comments · Fixed by #5185
Closed

[Image Carousel] Investigate issues with aspect ratio #5156

leecalcote opened this issue Nov 27, 2023 · 3 comments · Fixed by #5185
Assignees
Labels
framework/gatsby Gatsby related help wanted Extra attention is needed kind/enhancement New feature or request language/css

Comments

@leecalcote
Copy link
Member

Current Behavior

The image carousel component that is used on integration pages (like this one) skews images as they are presented in the side navigator.

Desired Behavior

Ideally, all images have their aspect ratio maintained at all times even if it means cropping an image or making it smaller to fit the given space.

Screenshots / Mockups

Screenshot 2023-11-27 at 8 23 13 AM

Implementation

  1. INvestigate and improve our documentation with respect to the ideal dimensions of the current image carousel's configuration.
  2. Document those image dimensions with respect to the side menu.
  3. Explore solutions that make image sizing dynamic, like use of object-fit.

Acceptance Tests

  1. Documentation is updated.
  2. Image aspect ratios are maintained.

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

@leecalcote leecalcote added kind/enhancement New feature or request help wanted Extra attention is needed framework/gatsby Gatsby related language/css labels Nov 27, 2023
@vishalvivekm
Copy link
Member

@leecalcote I'd like to investigate and fix the issue. Can it please be assigned to me ?

@ankushbhardwaj408
Copy link
Member

Screenshot 2023-11-27 203023
@leecalcote i think either contain or cover can work as in both cases the aspect ratio of the image will not change

@leecalcote
Copy link
Member Author

Thank you, gents. @ankushbhardwaj408, yes, I think that you're right that both are worth exploring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework/gatsby Gatsby related help wanted Extra attention is needed kind/enhancement New feature or request language/css
3 participants