Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsable Navigation Menu #304

Closed
2 tasks
leecalcote opened this issue Sep 27, 2019 · 6 comments
Closed
2 tasks

Collapsable Navigation Menu #304

leecalcote opened this issue Sep 27, 2019 · 6 comments
Assignees
Labels
hacktoberfest Happy contributing! help wanted Extra attention is needed kind/enhancement Improvement in current feature

Comments

@leecalcote
Copy link
Member

leecalcote commented Sep 27, 2019

Enhancement Description
As a user, I sometimes prefer to collapse the lefthand side navigation menu to only show icons and sometime prefer to see the full menu with labels for each navigation menu item.

Example
Untitled

Implementation

  • A new icon will need to be added to denote this action.
  • The icon used to collapse the menu should be placed in the lower, righthand side of the current navigation menu (see screenshot).

Screen Shot 2019-09-27 at 1 30 49 PM

@leecalcote leecalcote added kind/enhancement Improvement in current feature help wanted Extra attention is needed hacktoberfest Happy contributing! labels Sep 27, 2019
@mcastre
Copy link
Contributor

mcastre commented Oct 2, 2019

I can help you with this!

@leecalcote
Copy link
Member Author

@mcastre that would be just lovely. Yes, please. Here's a quick guide to contributing (note the steps specific to the UI).

Be sure to see the Meshery Contributors Welcome Guide and join this Slack, so that you might get to know more of the community being this project - http://slack.layer5.io.

@mcastre
Copy link
Contributor

mcastre commented Oct 2, 2019

Thanks @leecalcote! I'll get right on it!

@girishranganathan
Copy link
Contributor

@mcastre assigning the issue so that no one else will accidentally work on the same. . . 🙂

mcastre added a commit that referenced this issue Oct 8, 2019
Signed-off-by: Martin Castre <mcastre3@gmail.com>
leecalcote added a commit that referenced this issue Oct 10, 2019
#304 - Collapsible Side Navigation
girishranganathan pushed a commit that referenced this issue Oct 10, 2019
Signed-off-by: Martin Castre <mcastre3@gmail.com>
girishranganathan pushed a commit that referenced this issue Oct 10, 2019
#304 - Collapsible Side Navigation
@mcastre
Copy link
Contributor

mcastre commented Oct 15, 2019

@leecalcote can we close this issue? Im not sure but Hacktoberfest isnt counting this PR as completed

@leecalcote
Copy link
Member Author

@mcastre absolutely. Yes. Thanks for your good work here.

raghavaggarwal99 pushed a commit to raghavaggarwal99/meshery that referenced this issue Jan 10, 2020
Signed-off-by: Martin Castre <mcastre3@gmail.com>

Signed-off: raghavaggarwal99<ragha170103048@iitg.ac.in>
raghavaggarwal99 pushed a commit to raghavaggarwal99/meshery that referenced this issue Jan 10, 2020
meshery#304 - Collapsible Side Navigation
Signed-off: raghavaggarwal99<ragha170103048@iitg.ac.in>
raghavaggarwal99 pushed a commit to raghavaggarwal99/meshery that referenced this issue Jan 10, 2020
meshery#304 - Collapsible Side Navigation
Signed-off: raghavaggarwal99<ragha170103048@iitg.ac.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Happy contributing! help wanted Extra attention is needed kind/enhancement Improvement in current feature
Projects
None yet
Development

No branches or pull requests

3 participants