[mesheryctl] Merging PreRunE for command and Preflight checks

[piyushsingariya]

Description
Read the full description #2767

This PR fixes #2767

[netlify]

Deploy preview for meshery-docs ready!

Built with commit 077b484

https://deploy-preview-2779--meshery-docs.netlify.app

[pottekkat]

@piyushsingariya Shouldn't every preReqCheck be changed?

[piyushsingariya]

Yeah, they should be changed but i didn't because preflight checks are still an experimental feature.
Should i change them?? Or we can make a few "good first issues" out of this.

[pottekkat]

Yeah, they should be changed but i didn't because preflight checks are still an experimental feature.
Should i change them?? Or we can make a few "good first issues" out of this.

I think that it should be changed, unless we have any strong reason to do otherwise. The preflight checks have all the same functions as in the preRun function right? So unless we are missing anything, it would make sense to use the preflight function.

// @hexxdump @leecalcote

[piyushsingariya]

I think that it should be changed, unless we have any strong reason to do otherwise.

Waiting for a confirmation....

[hexxdump]

Yeah, they should be changed but i didn't because preflight checks are still an experimental feature.
Should i change them?? Or we can make a few "good first issues" out of this.

I think that it should be changed, unless we have any strong reason to do otherwise. The preflight checks have all the same functions as in the preRun function right? So unless we are missing anything, it would make sense to use the preflight function.

// @hexxdump @leecalcote

Agreed. However, not all commands call preRun function, wherever applicable, replace with preflight.

[leecalcote]

@hexxdump +1

[piyushsingariya]

@hexxdump @leecalcote @navendu-pottekkat I updated all the PreRunE with Preflight checks. 🥂

[pottekkat]

@piyushsingariya Looks good ⚡

[leecalcote]

@piyushsingariya, centralizing these check is fantastic. In terms of where they get exposed in the CLI, here's my thinking:

system check - checks on health of Meshery deployment (all components) in current context.
system check --adapter - checks on specific adapter; flag may be repeated.
system check --operator - verifies health of Meshery Operator deployment with MeshSync and Broker
system check --preflight - checks environmental prerequisites for deploying Meshery.
system check --report - runs diagnostics collection and bundles for opening an issue.

Given this, will you move preflight out of exp and move it from command to flag?

[piyushsingariya]

Given this, will you move preflight out of exp and move it from command to flag?

Yeah, I'll be removing the preflight command after this PR and will directly add the check command under exp and move preflight as a flag, and will start working on the other features under the same command.

[leecalcote]

Sounds good, @piyushsingariya. Two tweaks:

• you can move out of ‘exp’ now.
• let’s chat about other areas of need before more efforts on check.

[piyushsingariya]

let’s chat about other areas of need before more efforts on check.

@leecalcote I'm up for it! 💪 ✌️

[leecalcote]

@piyushsingariya here we are - #2823

[pottekkat]

@piyushsingariya #2823 has your name written all over it!

[leecalcote]

Looks good to me

[leecalcote]

Let's move forward and revisit as needed as we progress.