Snippets sqlvec fns take a connection instead of parameters map when using Conman

[jmayaalv]

A "Parameter Mismatch" exception is thrown when calling snippets that receive parameters when using Conman.

snippet:

FROM   trd_product p, trd_contract c
WHERE  p.productid = c.productid AND p.tenantid = :tenant-id

(search-snip {:tenant-id 1698})

This is the state of sqlvec-fn* when debugging:

Class: clojure.lang.PersistentArrayMap
Contents: 
  0. [ psql [ "FROM   trd_product p, trd_contract c\nWHERE  p.productid = c.productid AND\n       p.tenantid = " { :type :v, :name :tenant-id } ] ]
  1. [ options {} ]
  2. [ y hugsql.core$sqlvec_fn_STAR_$y__64066@2084d943 ]
  3. [ param-data { :datasource HikariDataSource (HikariPool-21) } ]
  4. [ opts { :tenant-id 1698 } ]

[jmayaalv]

As a workaround the snippet can be built using:
(edge-ui.db.core/search-snip {:tenant-id 1698} nil)

[csummers]

Thanks for the report.
What are your HugSQL and conman versions?

[jmayaalv]

conman "0.5.8"
hugsql "0.4.7"

[csummers]

You know, I think this may have been an issue since the beginning of conman+HugSQL and we just didn't catch it until now.

It looks like conman is missing a :meta on this line.

It is currently:

#(-> % second :snip? boolean)

but should be:

#(-> % second :meta :snip? boolean)

Pinging @yogthos on this. I'll create a conman pull request.

[yogthos]

Awesome, thanks!

[csummers]

For history's sake, I found the original issue where we put this in, and it really was at the beginning!

Thanks for helping out, @jmayaalv.

[jmayaalv]

Thanks a lot guys! you rule!