[BUG] Same games are listed multiple times

[psychrabi]

Describe the bug
Few games are listed multiple times in the games list

[p0ryae]

That's probably a bug. Please confirm if deleting com.lazap.config and relaunching lazap doesn't fix the issue. If it doesn't, please let me know about where those games are coming from (Steam? Epic Games? etc…). You may find the Enable Launcher Icons toggle useful in the appearances section of the settings.

[psychrabi]

Yes games are from steam and epic games and I did deleted folder from app data for testing the new version

…

On Thu, 18 Apr 2024, 7:04 am Porya, ***@***.***> wrote: That's probably a bug. Please confirm if deleting com.lazap.config and relaunching lazap doesn't fix the issue. If it doesn't, please let me know about where those games are coming from (Steam? Epic Games? etc…). You may find the Enable Launcher Icons toggle useful in the appearances section of the settings. — Reply to this email directly, view it on GitHub <#144 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEGHYC2VR7LVVIBK2IO2GVDY54NSLAVCNFSM6AAAAABGLA76BGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRSHAYTOOJRG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[p0ryae]

Please share your data.json file so we can investigate this further.

[LegItMate]

Insufficient information please do not overwrite the template.
Can you provide the OS you are using in this issue and #145?
Also what are the differences between this issue and #145?

[psychrabi]

this is different to the #145 is that only after a long time waiting, was i able to get the games list and the game list has duplicates of games as show in the screenshot in #144

I am using Windows 11 Pro build 22635.3420

[LegItMate]

Please share your data.json file so we can investigate this further.

We can try this now

[psychrabi]

2024-04-19.10-50-11.mp4

I tried reinstalling the app after deleting the folder before
and due to which my data.json is empty
and the game list is not showing at all.
I left the app for some hours and still didnot get the games to list.

[p0ryae]

Thanks for the video preview and the description.

Here's the To-Do:

1. Create a personalized build for you so you can check the logs.
2. Make it so users can debug lazap easier (eliminate the use of inspect element for debugging).
3. In the future, we should implument a loading animation (just for end-user) @LegItMate.

[psychrabi]

I cloned the repo to my local and ran it and got this error.
perhaps it should shed some light for you.

I have been following the repo for a while and learnt a log about tauri and rust backend.
Hope to contribute to the repo in future

[LegItMate]

I cloned the repo to my local and ran it and got this error.
I have been following the repo for a while and learnt a log about tauri and rust backend.
Hope to contribute to the repo in future

Yes, this is very much helpful

[LegItMate]

Do you have any games from uplay launcher?

[psychrabi]

Yes i have infact a game in ubisoft - TrackMania
and i have the game in Epic Games as well.

[LegItMate]

I want you to remove the lines 67-69 in this very same file and if everything works show me the data.json file inside %appdata%/com.lazap.config/cache/games

Make sure you remove all of this

"Uplay" => {
    ...
}

[p0ryae]

@psychrabi Since you mentioned you compiled lazap from source, please switch to the nightly branch and pull the latest changes.

I have commited 86469c4 which aims to solve the error you're experiencing.

Let me know if it solves it.

[psychrabi]

Yes, i am on nightly branch for testing.

And this has resolve the issue with the games list not loading for long time and loads after few seconds.,
However, i noticed something so i recorded a video and attached here

When the games load, at the first few seconds, there seems to be duplicate of games and then after few seconds the duplicates disappear.

2024-04-19.14-47-09.mp4

Another thing i noticed is some banners are not showing up and corresponding debug log is show in the terminal

[LegItMate]

1. It does happen because currently it loads all games and then removes any duplicates. For example, if you bought a GTA game through Epic Games then it will show that GTA game from Epic Games as well as from Rockstar Games, loading the same game twice before removing it.
   Some other cases that cause this could be loading of games multiple times in a very short time period, although I expect this to not happen.
   And looking at your recording, that's pretty unexpected behaviour.

2. The log means that it did not find a game from the API causing it to use the default banner. This issue will be there for Uplay Launcher's games currently. We will have to look forward to finding a better source for getting banners. Nothing you can do about it really except setting suitable banners manually.
   Although if there're banners missing for games that were installed through launchers other than Uplay Launcher then it's a concern

[p0ryae]

1. It does happen because currently it loads all games and then removes any duplicates.

Not really sure if this is the reason for him, because almost all of his games include this duplicate issue.

@psychrabi is your data.json in good shape? Does it include all of the games? Any duplicates you find in the data.json?

[psychrabi]

1. It does happen because currently it loads all games and then removes any duplicates.

Not really sure if this is the reason for him, because almost all of his games include this duplicate issue.

@psychrabi is your data.json in good shape? Does it include all of the games? Any duplicates you find in the data.json?

It seems the app also detected my previous installations to different drive.
which i deleted the games and reinstalled to the default paths.

which is why it showed few duplicate games (from 2 locations)

I will try again in a fresh windows install and see.
I have attached my data.json here

[psychrabi]

I did as i mentioned above and deleted all manifest files from older install path and now there is no duplicate games showing up .

[p0ryae]

It seems the app also detected my previous installations to different drive. which i deleted the games and reinstalled to the default paths.

Were they from Steam? Which Launcher(s) specifically if you can recall? Might be helpful to know in order to make the detection better.

I did as i mentioned above and deleted all manifest files from older install path and now there is no duplicate games showing up .

Please confirm if your problem is resolved. Also, is the loading faster (or improved) compared to the previous time?

[psychrabi]

There were from Epic Games
Only the game TrackMania was in both Epic games and Ubisoft with different names
and in Epic Games, if i deleted the game from one directly and reinstalled it on another the it was creating a new manifest file (*.item) in the manifest folder of epic games in programdata\epic

which seems to have caused the duplicate games as Lazap was reading all (*.item) files at first then removing the duplicate names afterwards

Now, the games loads in few seconds.

[psychrabi]

Issue is resolved as of yet.