Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting #17

Closed
gukodev opened this issue Jan 11, 2022 · 1 comment
Closed

Linting #17

gukodev opened this issue Jan 11, 2022 · 1 comment

Comments

@gukodev
Copy link
Contributor

gukodev commented Jan 11, 2022

Hey!

Do you guys approve use linting on this project (prettier)?
From what I checked, I saw that there is a mixture of tabs and 4-width spaces, and other things too.
With linting we can set a pattern for the code.

In my fork I'm also restructuring the project and I've already added linting:

📂 lazap
├─ 📂 src
│  ├─ 🎨 assets
│  │  ├─ ✒️ fonts
│  │  │    ...
│  │  └─ 📸 img
│  │       ...
│  ├─ 📂 main
│  │  └─ 📄 index.js # Project's main file
│  └─ 📂 renderer
│     ├─ 📂 css
│     │    ...
│     ├─ 📂 js
│     │  ├─ 📂 launchers
│     │  │    ...
│     │  ├─ 📂 login
│     │  │    ...
│     │  ├─ 📄 functions.js
│     │  ├─ 📄 ipc.js
│     │  └─ 📄 listeners.js
│     ├─ 📄 index.html
│     └─ 📄 login.html
└─ 📂 storage
   └─ 📄 userprofile.json

I just want your approval/discuss before making a pull request :)

@p0ryae
Copy link
Member

p0ryae commented Jan 11, 2022

Hello Gustavo,

Yes we do. Go on and create a pull request and I'll take a look at it.
I like the example layout!

Thanks for your work and effort in general for this repository <3

@gukodev gukodev closed this as completed Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants