Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a question about the publication #71

Closed
abedkurdi opened this issue Mar 17, 2021 · 2 comments
Closed

a question about the publication #71

abedkurdi opened this issue Mar 17, 2021 · 2 comments
Labels
documentation Changes to documentation

Comments

@abedkurdi
Copy link

Dear @lazappi,
'Clustree' is such an amazing piece of work that makes our job easier in clustering single-cell samples.
However, while reading your publication, under the "Building a Clustering Tree" section, directly under the figure, you say "Many of the edges will be empty, e.g., in Fig. 1 no samples in cluster A at k=2 end up in cluster B at k=3". As I am checking the figure, I noticed that it should be "... no samples in cluster A at k=2 end up in cluster C at k=3", am I right, or am I missing something?

Thanks in advance

@lazappi lazappi added the documentation Changes to documentation label Mar 18, 2021
@lazappi
Copy link
Owner

lazappi commented Mar 18, 2021

Hi @abedkurdi

Thanks for the kind words about {clustree} and clustering trees! I think you are right about there being a mistake in the manuscript 🙀. It should be either:

..in Fig.1 no samples in cluster A at k = 2 end up in cluster C at k = 3.

Or:

..in Fig.1 no samples in cluster B at k = 2 end up in cluster B at k = 3.

Hopefully that's obvious from looking at the figure and didn't cause too much confusion! It's a bit disappointing that we didn't catch it during the proofreading/reviewing process though 😿. Thanks for letting us know!

@lazappi lazappi pinned this issue Apr 22, 2021
@lazappi
Copy link
Owner

lazappi commented Apr 22, 2021

Closing this issue but going to leave it pinned for further reference.

@lazappi lazappi closed this as completed Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes to documentation
Projects
None yet
Development

No branches or pull requests

2 participants