Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added control of the node text rotation #80

Merged
merged 1 commit into from Jun 24, 2022

Conversation

kvittingseerup
Copy link

As you suggested in #79

@kvittingseerup kvittingseerup mentioned this pull request Jun 17, 2022
@lazappi
Copy link
Owner

lazappi commented Jun 21, 2022

Thanks! I've had a quick look at this and it seems to work. Couple of comments:

  • Could you please make a similar change to the clustree_overlay() function? I try to keep this in sync with clustree() as much as possible.
  • I have a policy of trying to include everyone who contributes to {clustree} as an author. If you are happy to do that please add your details to the authors list in DESCRIPTION and the contributors list in README.md.

@kvittingseerup
Copy link
Author

Ah sorry - was not aware of the clustree_overlay() function :-)

That does however cause a small problem as geom_label_repel() apparently does not support rotation.

Seems it would require switching to geom_text_repel() or geom_richtext(). Would that be acceptable or would you prefer it without the rotation option?

Thanks for the author offer - I do think this update is to small to qualify for that though :-)

@lazappi
Copy link
Owner

lazappi commented Jun 22, 2022

Ah sorry - was not aware of the clustree_overlay() function :-)

That does however cause a small problem as geom_label_repel() apparently does not support rotation.

Seems it would require switching to geom_text_repel() or geom_richtext(). Would that be acceptable or would you prefer it without the rotation option?

Ah, ok. In that case don't worry about it.

Thanks for the author offer - I do think this update is to small to qualify for that though :-)

Definitely not too small but if you would prefer not to that's up to you. You could just do the README list if you like.

@kvittingseerup
Copy link
Author

Again thanks for the author offer but I'll pass :)

Do you have an idea when the updated version will be on CRAN?

@lazappi
Copy link
Owner

lazappi commented Jun 24, 2022

I will try to submit it in the next day or so and assuming everything passes it should be up next week sometime. I am on leave from the end of next week though so if it doesn't happen by then it will be a while longer.

@lazappi lazappi changed the base branch from master to develop June 24, 2022 16:01
@lazappi lazappi merged commit 238981b into lazappi:develop Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants