Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database file unnecessary lines? #39

Closed
haze opened this issue Jun 20, 2017 · 4 comments
Closed

Database file unnecessary lines? #39

haze opened this issue Jun 20, 2017 · 4 comments

Comments

@haze
Copy link

haze commented Jun 20, 2017

Looking at the Pokemon database text file, the id's correspond to the line they are on, why bother with the id if it is also the line number?

@LazoCoder
Copy link
Owner

You are right, it's unnecessary. I didn't realize this when I created the file. But removing it would only reduce the project size by a few kilobytes which isn't much in the grand scheme of things.

@sylveon
Copy link
Collaborator

sylveon commented Jun 20, 2017

I reduced the size from 70 mb to 26 mb in the AUR package by adding these commands in the packaging process:

  rm .npmignore .gitignore LICENSE package.json
  rm -rf .git/ .idea/ Samples/ Scripts/

So I would assume Samples is taking a lot of that space (And I should really remove that -f)

@LazoCoder
Copy link
Owner

Awesome

@cclauss
Copy link
Contributor

cclauss commented Jun 22, 2017

What is the todo of this issue? Should something be added to the .gitignore file? Or can this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants