Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 4.0 Support #107

Merged
merged 12 commits into from Dec 10, 2021
Merged

Django 4.0 Support #107

merged 12 commits into from Dec 10, 2021

Conversation

johnthagen
Copy link
Collaborator

@johnthagen johnthagen commented Oct 24, 2021

Closes #76

Closes #108

#104 instates the policy for supporting supported Django versions and thus this PR is compatible with that new policy.

  • Officially support Django 2.2, 3.2, and 4.0, the versions of Django currently supported
  • Do not require Django to be installed simply to build the source distribution for django-solo. This enables testing to work when only tox is installed (e.g. CI)

@johnthagen johnthagen added the bug label Oct 24, 2021
@johnthagen johnthagen self-assigned this Oct 24, 2021
@johnthagen
Copy link
Collaborator Author

@lazybird Given that Django 4 is only a month away, I think it would be great if you were able to review this and #106, and we published a Django 4-compatible version of django-solo to PyPI before then.

@johnthagen
Copy link
Collaborator Author

@lazybird Another friendly ping to see if we can get this all released before Django 4.0 is released.

@Archmonger
Copy link

Archmonger commented Dec 8, 2021

@johnthagen If this package wants to maintain compatibility with Django 1.6+, the deprecated imports will need to remain.

Otherwise, the description needs to be updated to show the new minimum Django version.

Also, the same changes need to take place in solo/templatetags/solo_tags.py

@johnthagen
Copy link
Collaborator Author

If this package wants to maintain compatibility with Django 1.6+, the deprecated imports will need to remain.

@Archmonger Minimum Django version is specified in #104. Ultimately this is @lazybird's call, but in that PR I recommend following what most Django packages do which is to only support the currently supported Django versions. Users on older versions of Django can pin to older versions of django-solo.

The intention was to merge #104 before this PR and I was hoping @lazybird would give an official blessing on that PR before proceeding.

@johnthagen

This comment has been minimized.

@johnthagen johnthagen marked this pull request as draft December 8, 2021 13:19
@johnthagen johnthagen marked this pull request as ready for review December 9, 2021 00:32
@johnthagen johnthagen changed the title Remove deprecated Django imports and make compatible with Django 4.0 Django 4.0 Support Dec 9, 2021
@johnthagen
Copy link
Collaborator Author

@connor-makowski @frague59 Thank you for your contributions in your PRs. I've consolidated everything including automating testing into this PR.

Please review this PR.

@connor-makowski
Copy link

connor-makowski commented Dec 9, 2021

Confirming pip installing from the current branch (git+https://github.com/johnthagen/django-solo.git@4f8c586121cac4a08a9d05b52e8f7c23366a156d) is working for me in django 4.0. and in old projects in django 3.1.

Thanks @johnthagen

@johnthagen
Copy link
Collaborator Author

@connor-makowski Would you mind trying one more time? I added an explicit install_requires to setup.py so that pip can properly enforce dependency resolution. This should help notify users explicitly if they are trying to install django-solo on an unsupported Django version.

@johnthagen johnthagen merged commit a01ceeb into lazybird:master Dec 10, 2021
@johnthagen johnthagen deleted the django-4.0-support branch December 10, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Django 4.0 compatibility Django 4.x deprecation errors (ugettext + force_text)
4 participants