New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django 4.0 Support #107
Django 4.0 Support #107
Conversation
@lazybird Another friendly ping to see if we can get this all released before Django 4.0 is released. |
@johnthagen If this package wants to maintain compatibility with Django 1.6+, the deprecated imports will need to remain. Otherwise, the description needs to be updated to show the new minimum Django version. Also, the same changes need to take place in |
@Archmonger Minimum Django version is specified in #104. Ultimately this is @lazybird's call, but in that PR I recommend following what most Django packages do which is to only support the currently supported Django versions. Users on older versions of Django can pin to older versions of The intention was to merge #104 before this PR and I was hoping @lazybird would give an official blessing on that PR before proceeding. |
This comment has been minimized.
This comment has been minimized.
@connor-makowski @frague59 Thank you for your contributions in your PRs. I've consolidated everything including automating testing into this PR. Please review this PR. |
Confirming pip installing from the current branch (git+https://github.com/johnthagen/django-solo.git@4f8c586121cac4a08a9d05b52e8f7c23366a156d) is working for me in django 4.0. and in old projects in django 3.1. Thanks @johnthagen |
@connor-makowski Would you mind trying one more time? I added an explicit |
Closes #76
Closes #108
#104 instates the policy for supporting supported Django versions and thus this PR is compatible with that new policy.
django-solo
. This enables testing to work when onlytox
is installed (e.g. CI)