-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large number of null
in list
#9
Comments
I've seen other people get this but never gotten it myself. Can you please send me your bank list data so I can see how this looks in there? To find that data... Find the directory "C:\Users<username>.runelite" You can post it in here or DM me it on Discord if you don't want to post your bank items publicly (LazyFaith#9169 on Discord). |
Hmm yeah, I see what you mean. |
I've had it happen again on a smaller scale, just a couple of nulls near the end, they're showing up as
|
I've also found a reproduction! The nulls are added when you "release" bank placeholders. I think I managed to create so many the first time by releasing a whole tab. Edit: Scratch that, the bulk nulls are created when you drag an item onto a bank tab to move it to that tab, creates a whole lot of nulls
|
I'd love to contrib a patch for this if you wouldn't mind leaving the ticket for me, been wanting to look at how runelite plugins work anyway |
That's great, thank you for coming back with this info. The fix for this wouldn't really interact with the RuneLite APIs at all I don't think, you'd just be learning my code. I do have another small enhancement that I've been meaning to do for a while and would actually mean a bit of interaction with RuneLite's APIs so that may be better for you to do if you want to learn a bit more about RuneLite. You're welcome to do this but if you'd like to try the other then take a look at issue #10 and then I'll do this one. |
Doing it when creating a new bank save and when loading a bank save from the config should mean all new data is clean & all old data gets cleaned.
Fix should be be live. |
Sweet! Did you find out anything about why they're in the incoming stream to start with? |
I didn't to be honest! I just went off what you said for fixing it. I assume it's probably something in the base game that the bank interface knows to just ignore, or perhaps something RuneLite accidentally introduces. |
The text was updated successfully, but these errors were encountered: