Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scattering time step issue #1

Closed
walkerna22 opened this issue Apr 24, 2024 · 3 comments
Closed

scattering time step issue #1

walkerna22 opened this issue Apr 24, 2024 · 3 comments

Comments

@walkerna22
Copy link

photon scattering times are compared to the total time between hydro frames, instead of the remaining time in the current frame. This can cause photons to travel farther than they should in certain situations

@parsotat
Copy link
Member

Commit 362f587 should address this issue, please use that to verify that the issue has been resolved in the 16TI simulation and feel free to include your verification results here, comparing the old MCRaT results with the new (corresponding to the referenced commit) MCRaT results of the 16TI code.

@walkerna22
Copy link
Author

I ran the requested validation using that commit and the results agree with past MCRaT runs. The attached lightcurves and spectra agree with previously published results (the Ye=0.1 run in this paper https://iopscience.iop.org/article/10.3847/1538-4357/ad2dfa).

s_validate
lc_validate

@parsotat
Copy link
Member

This is great @walkerna22. thanks for running this software verification. I will go ahead and close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants