Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDS ISDA pricing engine #108

Closed
thrasibule opened this issue Jul 12, 2016 · 5 comments · Fixed by #112
Closed

CDS ISDA pricing engine #108

thrasibule opened this issue Jul 12, 2016 · 5 comments · Fixed by #112

Comments

@thrasibule
Copy link
Contributor

This is a revival of issue lballabio/quantlib-old#143. I rebased @pcaspers CDS branch on top of current master here thrasibule/QuantLib@1070866 and fixed a couple bugs.
On top of fixing the original issue (adding an extra day to the last period of a cds schedule), this branch adds a new ISDA pricer for cds. Using this new pricer, I can now tie exactly the computations of cds upfronts with bloomberg and the JPM/Markit code. I think this would be a great addition to QuantLib. What's the best way of gettings this merged? I can try to squash the branch into a series of logical commits, but since @pcaspers and @japari did most of the work, I don't want to steal their thunder.

@pcaspers
Copy link
Contributor

As far as I am concerned this sounds good, go ahead. Do we have test cases for the ISDA pricer comparing the QL results with some references?

@lballabio
Copy link
Owner

Yes, it's ok for me if you just open a PR without squashing.

@japari
Copy link
Contributor

japari commented Jul 14, 2016

Hi, yes, needless to say, in the spirit of the endeavour here.
Good point Peter, I endorse it.
Best
pp

----- Original Message -----

As far as I am concerned this sounds good, go ahead. Do we have test
cases for the ISDA pricer comparing the QL results with some
references?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub , or mute the thread
.

@thrasibule
Copy link
Contributor Author

Great, I'll try to submit a pull request today. Regarding reference cases, I'll add some tests based on the grids that Markit publish here: http://www.cdsmodel.com/cdsmodel/test-grids.html?

@pcaspers
Copy link
Contributor

Some tests against these values would be perfect. Thanks a lot for your work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants