Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not build with thread-pool 4 #60

Closed
tillea opened this issue Nov 18, 2021 · 3 comments
Closed

Does not build with thread-pool 4 #60

tillea opened this issue Nov 18, 2021 · 3 comments

Comments

@tillea
Copy link

tillea commented Nov 18, 2021

Hi,
I checked issue 195 of the old repository of racon and thus was optimistic to try it in connection with thread-pool 4.0.0. Unfortunately I get

/build/racon-1.4.21/src/polisher.cpp: In lambda function:
/build/racon-1.4.21/src/polisher.cpp:494:41: error: 'using element_type = class thread_pool::ThreadPool' {aka 'class thread_pool::ThreadPool'} has no member named 'thread_ids'; did  you mean 'thread_map'?
  494 |                 auto it = thread_pool_->thread_ids().find(std::this_thread::get_id());  // NOLINT
      |                                         ^~~~~~~~~~
      |                                         thread_map
/build/racon-1.4.21/src/polisher.cpp: In lambda function:
/build/racon-1.4.21/src/polisher.cpp:494:41: error: 'using element_type = class thread_pool::ThreadPool' {aka 'class thread_pool::ThreadPool'} has no member named 'thread_ids'; did  you mean 'thread_map'?
  494 |                 auto it = thread_pool_->thread_ids().find(std::this_thread::get_id());  // NOLINT
      |                                         ^~~~~~~~~~
      |                                         thread_map
[ 64%] Building CXX object CMakeFiles/racon.dir/src/window.cpp.o
/usr/bin/c++ -DRACON_VERSION=\"v1.4.21\" -I/build/racon-1.4.21/src -I/build/racon-1.4.21/obj-x86_64-linux-gnu/config -g -O2 -ffile-prefix-map=/build/racon-1.4.21=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -pedantic -pthread -std=c++11 -MD -MT CMakeFiles/racon.dir/src/window.cpp.o -MF CMakeFiles/racon.   dir/src/window.cpp.o.d -o CMakeFiles/racon.dir/src/window.cpp.o -c /build/racon-1.4.21/src/window.cpp
make[3]: *** [CMakeFiles/racon_test.dir/build.make:107: CMakeFiles/racon_test.dir/src/polisher.cpp.o] Error 1

Any idea what might went wrong here?
Kind regards, Andreas.

@rvaser
Copy link
Collaborator

rvaser commented Nov 25, 2021

Hello,
there were some API changes, renaming thread_ids to thread_map should resolve this.

Best regards,
Robert

@tillea
Copy link
Author

tillea commented Sep 29, 2022

Any news whether racon has been able to adapt to the new thread_pool library API?

@rvaser
Copy link
Collaborator

rvaser commented Sep 29, 2022

It was resolved on Nov 25, 2021, v1.5.0.

@rvaser rvaser closed this as completed Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants