Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undici library causes tests to fail in the browser (Karma). #314

Open
AndreWillomitzer opened this issue Dec 10, 2021 · 0 comments
Open

Comments

@AndreWillomitzer
Copy link
Contributor

Hello! I have been working on this issue for a few weeks with one of the maintainers @kibertoad and figured I should make a formal issue so that even if we don't get it done, whoever does can link to the issue in their PR and close it.

The Issue

The tests that exist in the test directory use Undici requests which are not browser compatible. If you attempt to run the tests using Karma it will give many errors.

Here is the link to the in progress PR:

#306

I have set up Karma config, typescript pre-processing for it, and changed a few import statements to try and get Undici working.
@kibertoad I think was suggesting to just leave the Undici stuff for now and merge the Karma config and the changes that won't break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant