Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky NNDC tests failing #332

Closed
1 task done
jccurtis opened this issue Mar 31, 2022 · 5 comments · Fixed by #333
Closed
1 task done

Flaky NNDC tests failing #332

jccurtis opened this issue Mar 31, 2022 · 5 comments · Fixed by #333
Assignees

Comments

@jccurtis
Copy link
Collaborator

jccurtis commented Mar 31, 2022

We still have the flaky tests failing in the CI. See this pipeline

  • Add to dev requirements
@jvavrek
Copy link
Contributor

jvavrek commented Apr 1, 2022

Those tests are indeed marked with flaky but it's possible they failed all three times if the NNDC server was down for a few seconds:

@pytest.mark.flaky(reruns=3)
class TestDecayRadiationQuery(NNDCQueryTests):

@jccurtis
Copy link
Collaborator Author

jccurtis commented Apr 1, 2022

@jvavrek can we all a timeout between reruns?

@jvavrek
Copy link
Contributor

jvavrek commented Apr 1, 2022

Oh and the package is not pytest-flaky but pytest-rerunfailures, which is in requirements-dev.txt.

@jccurtis
Copy link
Collaborator Author

jccurtis commented Apr 1, 2022

Maybe we can add the following to try three times with a 2 second delay only for

@pytest.mark.flaky(reruns=3, reruns_delay=2, only_rerun=NNDCRequestError)

(Not sure on the only_rerun syntax - it might need to be a string or a list of exceptions.)

@jvavrek
Copy link
Contributor

jvavrek commented Apr 1, 2022

Maybe we can add the following to try three times with a 2 second delay only for

@pytest.mark.flaky(reruns=3, reruns_delay=2, only_rerun=NNDCRequestError)

(Not sure on the only_rerun syntax - it might need to be a string or a list of exceptions.)

I don't think that's supported yet: pytest-dev/pytest-rerunfailures#164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants