Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding errors in final time give warning in BuildingsPy #363

Closed
mwetter opened this issue May 11, 2020 · 1 comment · Fixed by #396
Closed

Rounding errors in final time give warning in BuildingsPy #363

mwetter opened this issue May 11, 2020 · 1 comment · Fixed by #396
Assignees

Comments

@mwetter
Copy link
Member

mwetter commented May 11, 2020

Running ../bin/runUnitTests.py -t optimica gives output that includes

*** Warning: While processing file Buildings_Fluid_Geothermal_Borefields_BaseClasses_HeatTransfer_ThermalResponseFactors_Validation_GFunction_100boreholes_result.mat for variable gFun_int: different end time between reference and test data.
tNew = [0.0, 370000000000.0]
tOld = [0.0, 370000003072.0]

*** Warning: While processing file Buildings_Fluid_Geothermal_Borefields_BaseClasses_HeatTransfer_ThermalResponseFactors_Validation_GFunction_SmallScaleValidation_result.mat for variable gFun_int: different end time between reference and test data.
tNew = [0.0, 1800000000000.0]
tOld = [0.0, 1799999979520.0]

This issue is to avoid such rounding errors.

@mwetter
Copy link
Member Author

mwetter commented May 11, 2020

This issue should also correct the code that leads to

*** Warning: While processing file Buildings_Utilities_IO_Files_Examples_CSVReader_result.mat for variable cos.y: funnel binary status code is: 1.
Reference and test data minimum x values are different.

assuming this is also caused by a rounding error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants