-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge ice tank model #2820
Comments
@YangyangFu : Thanks, I created the branch |
The current tank model contains built-in control for the outlet temperature during discharging. This makes it hard to use model for configurations such as this (unless cascading control where used, which is not needed and adds complexity): Therefore, the model should be edited to move the control out of the component. Todo:
|
@mwetter can you please create a new branch so that I can make a pull request?
Or you can get the model here: https://github.com/BE-HVACR/modelica-ice-tank/tree/release_for_mbl.
The current implementation is validated against onsite measurement data, which contain three discharging experiments (with various discharging rate) and one charging experiment (with fixed charging rate). The data and descriptions are also documented in the implementation. More details can be found in the following reference.
The text was updated successfully, but these errors were encountered: