You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This ticket is to refactor classes within Templates to use a subrecord with all configuration (structural) parameters—intantiated as cfg. This subrecord must be declared in the master record datand in the components so that
structural parameters be propagated up with dat(cfg=<instance_name>.cfg) instead of
UserProject.Data.AllSystems dat(VAV_1(
final typ=VAV_1.typ,
final typFanSup=VAV_1.typFanSup,
final typFanRet=VAV_1.typFanRet,
final typFanRel=VAV_1.typFanRel,
...
final typCtl=VAV_1.ctl.typ,
final typSecOut=VAV_1.ctl.typSecOut,
final buiPreCon=VAV_1.ctl.buiPreCon,
ctl(
stdEne=VAV_1.ctl.stdEne,
stdVen=VAV_1.ctl.stdVen,
have_CO2Sen=VAV_1.ctl.have_CO2Sen)))
and design parameters be still propagated down with component(dat=dat) without any circular dependency.
The development branches issue1374_template_CHW_final and issue3266_template_HW_plant shall use the same construct.
The changes are backward-compatible with ctrl-flow mappings because the latter ones rely on locally declared configuration parameters which are not modified (except for the ones in Buildings.Templates.(AirHandlersFans|ZoneEquipment).Data but these are not involved in any mappings). The changes rather introduce a new record instance that "groups" all these parameters into a single object that can be easily propagated.
Update template development guide.
Update release notes (once MBL v10 is released).
Refactor CHW and HW plant templates with the same construct (once this PR has been reviewed).
The text was updated successfully, but these errors were encountered:
This ticket is to refactor classes within
Templates
to use a subrecord with all configuration (structural) parameters—intantiated ascfg
. This subrecord must be declared in the master recorddat
and in the components so thatdat(cfg=<instance_name>.cfg)
instead ofcomponent(dat=dat)
without any circular dependency.The development branches
issue1374_template_CHW_final
andissue3266_template_HW_plant
shall use the same construct.TODO:
Check that the changes are compatible with https://github.com/lbl-srg/ctrl-flow-dev/blob/main/server/scripts/sequence-doc/src/version/Current%20G36%20Decisions/Guideline%2036-2021%20(mappings).csv
Buildings.Templates.(AirHandlersFans|ZoneEquipment).Data
but these are not involved in any mappings). The changes rather introduce a new record instance that "groups" all these parameters into a single object that can be easily propagated.Update template development guide.
Update release notes (once MBL v10 is released).
Refactor CHW and HW plant templates with the same construct (once this PR has been reviewed).
The text was updated successfully, but these errors were encountered: