Accessibility audit, fixes and accessibility statement update #162
Conversation
app/components/static-page.hbs
Outdated
| @@ -6,7 +6,7 @@ | |||
| sizes="50vw" | |||
| src="/assets/images/loket-header-1600.jpg" | |||
| srcset="/assets/images/loket-header-320.jpg 320w, /assets/images/loket-header-1024.jpg 1024w, /assets/images/loket-header-1600.jpg 1600w" | |||
| alt="" role="presentation" | |||
| alt="een laptop met daarop het vlaanderen icoon" | |||
There was a problem hiding this comment.
We removed that alt text by choice, actually. This seems to be a decorative image and I don't think a person using a screenreader needs or wants to know that information?
There was a problem hiding this comment.
Ok, removed the alt text. It's a bit strange to use role="presentation" (removes the image completely from the accessibility API and an empty alt text is enough) here but it seems that the linter requires it.
There was a problem hiding this comment.
Yes, I agree. I discussed this in the ember discord a11y channel and the person responsible for the a11y linting rules ensured me that it was working as intended. After a linking to specific parts of the spec she backtracked and said the rule needed to be updated but I don't think that happened yet.
| @@ -11,7 +11,7 @@ | |||
| class="au-c-link" | |||
| target="_blank" | |||
| rel="noopener noreferrer" | |||
| >handleiding</a>. | |||
| >handleiding (externe link)</a>. | |||
There was a problem hiding this comment.
question: I've been thinking about creating a dedicated ExternalLink or LinkExternal component, do you think that is something that can be useful for other projects? In that case it might make sense to add it to ember-appuniversum instead.
There was a problem hiding this comment.
Yes, could be helpful as we use it in most projects.
Fixes:
Update: