Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validations to the person creation and edit pages #169

Merged
merged 4 commits into from
Sep 21, 2021
Merged

Add validations to the person creation and edit pages #169

merged 4 commits into from
Sep 21, 2021

Conversation

Windvis
Copy link
Contributor

@Windvis Windvis commented Sep 20, 2021

This adds basic validations to both the person creation and edit pages. It also includes the groundwork to make adding validations possible.

gcapurso
gcapurso approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@gcapurso gcapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, now thanks to the error states to the EditCard component we can implement all the logics behind the mandatory fields validation.

@gcapurso gcapurso merged commit 721c379 into master Sep 21, 2021
@gcapurso gcapurso deleted the chore/person-validations branch September 21, 2021 08:27
@Windvis Windvis changed the title Implement person validations Add validations to the person creation and edit pages Nov 18, 2021
@Windvis Windvis added the enhancement New feature or request label Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcapurso gcapurso gcapurso approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Windvis @gcapurso