Add validations to the site creation and edit pages #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helper can be used to reuse certain help text messages.
Windvis
requested changes
Oct 13, 2021
app/controllers/administrative-units/administrative-unit/sites/site/edit.js
Outdated
Show resolved
Hide resolved
app/controllers/administrative-units/administrative-unit/sites/site/edit.js
Outdated
Show resolved
Hide resolved
Windvis
reviewed
Oct 13, 2021
- always make the address mandatory
- fix an issue were the previous primary site was "lost" when creating a new one or when marking an existing site as primary
- fix an issue where a site was listed twice after changing it from non-primary to primary
- remove the records when leaving the page
- add help text were needed
- validation tweaks:
- the telephone regex is less strict
- the website needs to be prefixed with http(s)
- the full address can either always be required or when 1 field has been edited
Windvis
force-pushed
the
feature/sites-validations
branch
from
daf3d77
to
a2017dc
Compare
Windvis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.