Add support for deep linking to resources from external applications #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windvis
force-pushed
the
feature/direct-link-redirect
branch
from
bfede4e
to
e599201
Compare
Windvis
commented
Oct 18, 2021
Windvis
commented
Oct 18, 2021
Windvis
commented
Nov 2, 2021
Windvis
force-pushed
the
feature/direct-link-redirect
branch
from
e599201
to
4d5c389
Compare
This allows users to be redirected to the correct page based on a resource URI. The resource URI is used to retrieve the RDF type(s) and uuid of a resource which will then be mapped to the correct RedirectHandler class. The current implementation supports direct linking to "people" and "worship administrative units".
Windvis
force-pushed
the
feature/direct-link-redirect
branch
from
4d5c389
to
1a85dad
Compare
|
I'm merging this myself for now. It seems to work as expected. I just wanted some extra eyes on the implementation but we can always refactor in the future. |
Windvis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements direct linking to people and "worship administrative units".
It can be tested by using the following url:
http://localhost:4200/redirect?resource=add-resource-uri-hereIf the type of the resource is supported it should go to the correct page, else it will show the index page instead for now.
Requires this branch in the backend app: lblod/app-organization-portal#57