Add a page where users can run SPARQL queries #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windvis
requested changes
Nov 9, 2021
There was a problem hiding this comment.
I think you are using npm 7+ which causes a lot of changes to the lock file that aren't really needed. This is also the reason why CI fails since we are still using node 12 + npm 6 there.
I would try to use the same versions on your dev machine to prevent this from happening (take a look at volta in case you don't know it yet).
Windvis
reviewed
Nov 9, 2021
Windvis
reviewed
Nov 9, 2021
Windvis
reviewed
Nov 10, 2021
| export default modifier(function yasgui(element /*, params, hash*/) { | ||
| Promise.all([ | ||
| import('@triply/yasgui'), | ||
| import('@triply/yasgui/build/yasgui.min.css'), |
There was a problem hiding this comment.
I also tried lazy-loading the css and that seems to work. Saves another 9KB for users who don't visit that page 😄
Windvis
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.