Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Province is a required field on some pages #218

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

nbittich
Copy link
Collaborator

@nbittich nbittich commented Nov 25, 2021

When integrating CRAB we removed the requirement to fill in a province since this information is not provided by CRAB. End users still expect the province to be there for administrative units since they can filter the search using that data. So this adds back the requirement for certain pages.

app/validations/address.js Outdated Show resolved Hide resolved
app/validations/address.js Outdated Show resolved Hide resolved
@Windvis Windvis enabled auto-merge (squash) November 25, 2021 10:42
@Windvis Windvis merged commit 843b495 into development Nov 25, 2021
@Windvis Windvis deleted the feature/province-required branch November 25, 2021 10:44
Windvis added a commit that referenced this pull request Nov 25, 2021
@Windvis Windvis restored the feature/province-required branch November 25, 2021 10:47
nbittich added a commit that referenced this pull request Nov 25, 2021
Windvis pushed a commit that referenced this pull request Nov 25, 2021
@Windvis Windvis changed the title province is required in some cases Province is a required field on some pages Nov 25, 2021
@Windvis Windvis added the bug Something isn't working label Nov 25, 2021
@Windvis Windvis deleted the feature/province-required branch November 25, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants