Validate that a KBO number is 10 digits long before saving #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windvis
requested changes
Dec 15, 2021
There was a problem hiding this comment.
Another thing I would add is some help text below the input fields, similar to the phone number help text for example.
Maybe something like this?
Formaat: 0123456789
This can be added here: https://github.com/lblod/frontend-contact-hub/blob/015b2fe8f2bf90571da4aac14c2fbdfff4fb6ff7/app/helpers/help-text.js#L4-L10
and then used like {{help-text "kbo"}} in both the edit and creation page.
Windvis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.