Change events management #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the Ember Data model matches the updated change event model in the backend.
Co-authored-by: Sam Van Campenhout <sam.van.campenhout@gmail.com>
Implement the change event overview page
The previous naming was confusing since it implied that it was a 1 to 1 relationship.
* Add a `validateUrl` validator * `AdministrativeUnitSelect` component improvements These changes make the component more generic so that it can be used on other pages. * Implement the change event creation page * Hide the change event description label if it's empty The description isn't required when creating a change event so it's possible that it doesn't contain any data.
* Only load the decision record when needed Some change event types don't require decisions so we don't need to try to load that data either. * Only validate and save a decision when needed Some change event types don't require decision information so those cases we don't need to validate and save it either. * Delete unsaved change event records When the user leaves the page before saving the in-memory records need to be removed again.
This ensures the organization status is in sync with the most recent change event result status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes all the work that has been done for the change events pages.
It's not perfect yet, but it's in a testable state, so we can hand it over to the testing team while we iron out the remaining issues.