Fix a problem were saving didn't work in some cases on the local involvements page #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to use regular functions as helpers which means we need to write less boilerplate and can easily reuse logic in both the template and js files.
We now check if there are any financial organizations before triggering the total percentage validation. This fixes a problem were a valid form was marked invalid and prevented users from saving.
|
FYI Don't squash and merge this PR please, the separate commits are useful for the history in this case. 😄 |
nbittich
approved these changes
Jan 26, 2022
Windvis
added a commit
that referenced
this pull request
Jan 26, 2022
…#249) We now check if there are any financial organizations before triggering the total percentage validation. This fixes a problem were a valid form was marked invalid and prevented users from saving.
Windvis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now check if there are any financial organizations before triggering the total percentage validation. This fixes a problem were a valid form was marked invalid and prevented users from saving.