Add support for primary and secondary contact information #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a lot of commits since I created a commit for each page. I might reduce this by combining all related pages into one commit? |
Windvis
force-pushed
the
feature/support-primary-secondary-contact-information
branch
2 times, most recently
from
4a31d52
to
8e894bd
Compare
Windvis
force-pushed
the
feature/support-primary-secondary-contact-information
branch
from
cb8690f
to
452a959
Compare
… work with it This type will be used to differentiate between "primary" and "secondary" contact information.
This can be used to request address and contact information for a site, which we do on the administrative unit core data pages and on the site pages.
- Add a secondary phonenumber field - Update the labels
This can be used to display address and contact information for a site.
- Add a secondary phone number field - Update the labels to "primair" and "secundair"
- Add a secondary telephone field - Update the labels to "primair" and "secundair"
- Add a secondary phone number field - Update the labels to "primair" and "secundair"
This can be used to edit the address and contact information for a position.
- Add a secondary phone number field - Update the labels to "primair" and "secundair"
- Add a secondary phone number field - Update the labels to "primair" and "secundair"
- Add a secondary phone number field - Update the labels to "primair" and "secundair"
- Add a secondary phone number field - Update the labels to "primair" and "secundair"t
- Add a secondary phone number field - Update the labels to "primair" and "secundair"t
- Add a secondary phone number field - Update the labels to "primair" and "secundair"t
This util is replaced by a version that uses the `type` attribute instead.
nbittich
force-pushed
the
feature/support-primary-secondary-contact-information
branch
from
452a959
to
61bca03
Compare
nbittich
approved these changes
Feb 2, 2022
nbittich
deleted the
feature/support-primary-secondary-contact-information
branch
nbittich
pushed a commit
that referenced
this pull request
Feb 10, 2022
* Add a type attribute to the contact-point model and some utilities to work with it This type will be used to differentiate between "primary" and "secondary" contact information. * Create a `<Site::ContactEditCard>` component This can be used to request address and contact information for a site, which we do on the administrative unit core data pages and on the site pages. * Update the contact section on the administrative unit creation page - Add a secondary phonenumber field - Update the labels * Update the contact section on the administrative unit edit page * Create a `<Site::ContactDataCard>` component This can be used to display address and contact information for a site. * Update the contact section on the administrative unit details page - Add a secondary phone number field - Update the labels to "primair" and "secundair" * Update the contact section on the site creation page - Add a secondary telephone field - Update the labels to "primair" and "secundair" * Update the contact section on the site edit page * Update the contact section on the site details page - Add a secondary phone number field - Update the labels to "primair" and "secundair" * Create a `<Position::ContactEditCard>` component This can be used to edit the address and contact information for a position. * Update the contact section of the mandatory creation page - Add a secondary phone number field - Update the labels to "primair" and "secundair" * Update the contact section of the mandatory edit page - Add a secondary phone number field - Update the labels to "primair" and "secundair" * Create a `<Position::ContactDataCard>` component * Update the contact section of the mandatory details page - Add a secondary phone number field - Update the labels to "primair" and "secundair" * Allow passing in `@model` and `@models` arguments to the edit button component * Link to the mandatory edit page from the position details page * Update the contact section on the minister creation page - Add a secondary phone number field - Update the labels to "primair" and "secundair"t * Update the contact section on the minister edit page - Add a secondary phone number field - Update the labels to "primair" and "secundair"t * Update the contact section on the minister details page - Add a secondary phone number field - Update the labels to "primair" and "secundair"t * Remove the previous `findPrimaryContact` util This util is replaced by a version that uses the `type` attribute instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for adding a secondary telephone number on all pages with contact information or updates the labels of the ones that already supported this.
It expects that the migrations from lblod/app-organization-portal#88 ran already. Once we merge this we can also merge that PR.