Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to reset selected images #59

Closed
wants to merge 1 commit into from
Closed

Conversation

robtimp
Copy link

@robtimp robtimp commented Nov 19, 2015

If an image is already selected when a user taps 'Take Photo', it will skip to the secondary action because the numberOfSelectedImages is already > 0, and the photo is added, rather than presenting the camera UI as expected.

Note that the example app avoids this scenario, because the 'Take Photo' action is no longer available once a photo is selected.

This PR adds the ability for an action to reset the selected images, allowing the 'Take Photo' action to work as expected.

@lbrndnr
Copy link
Owner

lbrndnr commented Dec 14, 2015

Sorry it took me this long to respond.
If I'm not mistaken you can just initialize an action with a primary title and handler only to achieve what you're looking for or is that not it?

@robtimp
Copy link
Author

robtimp commented Dec 23, 2015

@larcus94 In this case, I still want a secondary handler for the action, I just don't want that handler to be triggered until after the primary handler, but when images are already selected, we jump immediately to the secondary handler.

I just thought it might be useful to add a 'reset' option for these cases.

@lbrndnr
Copy link
Owner

lbrndnr commented Apr 24, 2016

Hi @robtimp,

I'm not going to add this feature. I thought about it and I think that it's just not worth it.
Sorry for taking so long to respond, I'm so busy with uni.

Thanks for opening the pull request though!

@lbrndnr lbrndnr closed this Apr 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants