-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On the Swift3 branch: Denying access to photo library, and presenting an alertController on top of presented image picker sheet => crash #97
Comments
Can you please describe how I could reproduce this crash in more details? Or provide a video if it's easier for you. |
Sure thing, here's a bit more information. I have reproduced the crash on a devicerunning iOS10 and simulator running both iOS9 and iOS10 Step by step, this is what happens.
I have been through the exact same flow pre-swift3, and checked that the ImagePickerSheetController is dealloced correctly - it is. |
The issue here is that we try to access the user photos even if we're not allowed to. IMO, we shouldn't even show on screen the IPSC when we don't have the permission. My solution would be to implement an Any thoughts on your side @lbrndnr? |
Hmm, I think this depends on what the user puts in the two buttons. I appreciate that it most probably will be "image from photos" and "take picture" (camera) - but it could be stuff like "select image from dropbox", or "record voice message" instead. In these cases, the sheet controller should still be presented - but without the image strip methinks. |
Still no solution or any update for those issues? |
Yeah - fairly certain this library is now abandoned. Author is (if I understand correctly) working on a newer, iOS10-like-messages pane now. |
@kevinlee85 @scottcc Yes, that's the plan. I'm very busy with uni though so I haven't had time to work on it in a while... |
The app crashes in the ImagePickerSheetController deinit method.
The text was updated successfully, but these errors were encountered: