Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL Encoded LBRY links from explorer #23

Closed
tzarebczan opened this issue Apr 9, 2018 · 6 comments
Closed

Fix URL Encoded LBRY links from explorer #23

tzarebczan opened this issue Apr 9, 2018 · 6 comments
Labels
needs: exploration Solution unclear, needs research priority: low Work should be done but can stay in the backlog for now type: bug Existing functionality is wrong or broken

Comments

@tzarebczan
Copy link
Contributor

https://explorer.lbry.io/claims/6bbd31d0e1bcbcf7735ff7b35bcca322a24ec64b

When clicking open in LBRY, the app fails to open the file because of a % in the URL.

https://open.lbry.io/@unclejed613/lbry2 works but https://open.lbry.io/%40unclejed613%2Flbry2 does not.
@tzarebczan tzarebczan added the type: bug Existing functionality is wrong or broken label Apr 9, 2018
@QuirkyRobots
Copy link
Contributor

QuirkyRobots commented May 2, 2018 •
edited

There is also HTML being outputting over the thumb. Not sure if it's related?

image
image

@QuirkyRobots
Copy link
Contributor

QuirkyRobots commented May 2, 2018 •
edited

@tzarebczan Further to this. Both links in example above work, maybe you meant this link from the Open in LBRY button, which breaks the app for me?

Open in LBRY: lbry://%40unclejed613/lbry2

@tzarebczan tzarebczan mentioned this issue May 2, 2018
Closed
@tzarebczan
Copy link
Contributor Author

Yes, that's what this issue is for - when clicking Open in LBRY the app doesn't handle some of the encoding currently.

Opened #25 for the html issue.

@marcdeb1 marcdeb1 mentioned this issue Oct 10, 2018
Merged
@marcdeb1
Copy link
Contributor

This claim had a thumbnail with html characters (). Issue is fixed by escaping html characters.

@alyssaoc
Copy link

@akinwale Can you confirm if this has been fixed?

@alyssaoc alyssaoc added the needs: exploration Solution unclear, needs research label Nov 12, 2018
@alyssaoc alyssaoc added the priority: low Work should be done but can stay in the backlog for now label Nov 26, 2018
@tiger5226
Copy link
Contributor

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs: exploration Solution unclear, needs research priority: low Work should be done but can stay in the backlog for now type: bug Existing functionality is wrong or broken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tiger5226 @tzarebczan @alyssaoc @marcdeb1 @QuirkyRobots