Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable play button after clicking download #987

Merged
merged 1 commit into from Feb 5, 2018
Merged

Enable play button after clicking download #987

merged 1 commit into from Feb 5, 2018

Conversation

miikkatu
Copy link
Contributor

@miikkatu miikkatu commented Feb 4, 2018

Fixes #906 by ignoring the isLoading prop when determining the disabled state of the button.

@tzarebczan
Copy link
Contributor

@miikkatu thanks for the PR. We'll have our devs review it for correctness.

Please see https://lbry.io/faq/tips if you'd like to be compensated for your contribution.

Copy link
Contributor

@liamcardenas liamcardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works well. Code looks good. Thanks!

@liamcardenas liamcardenas merged commit 12effb9 into lbryio:master Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants