-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spacebar doesnt work flawless with handlers #3870
Comments
Thanks for filing this issue, I can confirm it's happening. Can we show you some appreciation for the report? |
sure thing, |
Is this browser specific? Didn't happen to me on Firefox. |
I couldn't reproduce it on any browser or even the app. 😕 |
I've been able to reproduce this in both the app and on Chrome. It's my understanding that the default spacebar behavior in most browsers is to scroll down when the miniplayer isn't in focus. However, as soon as the miniplayer is brought back into focus it only pauses the video. I think the best way to handle this would be to add an event listener that would disable the default behavior if a user presses spacebar. I'm not sure if there's any situation where you would want to keep this default behavior in place, so just thought I'd mention it just in case. Either way, I can start working on this within the next couple days. |
Bug
when i press on the spacebar on my keyboard with the miniplayer playing a video, 2 things happen: the page scrolls down, and the video pauses playing in miniview.
To Reproduce
as explained above
Expected behavior
expected behaviour to me would naturally be in this case: spacebar press to only pause/resume and not scroll the page. maybe use the page up/down keys for that specific?
System Configuration
Additional context
love LBRY alot! just wish i could help fixing the issues i come across :)
The text was updated successfully, but these errors were encountered: