Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Content shown as free at overtaken claim, users charged for downloads #797
When content is overtaken at a vanity URL that was previously cached, the new claim information is shown but the content price is not updated. There's a possibility that the content price is now 10 LBC but the app will still show 0. When the content is streamed or downloaded, the user is charged 10LBC unknowingly.
The original issue was first reported in #511 and then was supposed to be fixed in #511 but still continues to occur. Recently we had a user charged 130LBC for lbry://nine because there was a takeover that didn't show the correct price.
This is most likely related to a more complex "when to refresh cached data" discussed here #451 (comment) but I think something needs to be done in the interim to prevent the scenario where users are charged for seemingly free content.
Steps to reproduce
Claim being shown as free upon re-entering it:
Charged for content upon downloading:
Tell us what should happen
Tell us what happens instead
duplicate of #803
@lyoshenka I don't think it's a duplicate.. I was going to mention that on the call but didn't want to prolong the conversation anymore.
This issue is more of a pricing update problem... Someone can overtake a claim and set a high lbc price and the person going to that claim will see the old price (or free).
There's a bit of timing involved, but this has happened in the past and I'm able to reproduce it.
Maybe it has to do more with the general "when do we invalidate cache" issue, not sure. But I was hoping to have a more short term solution which would product users by refreshing the price before purchase or something.
Looks like it was moved to lbry from lbry-app, not sure where it belongs.
@tzarebczan can you reproduce this issue using only lbrynet? I suspect this is a lbry-app issue involving caching, but if you can reproduce it in lbrynet, then this is the appropriate repo.
If you can ever call
I'll move this back to the app side.
referenced this issue
Nov 29, 2017
referenced this issue
Feb 5, 2018
This happened to me with lbry://three today. File was listed as free, and it charged me 10 LBC. Did not download. Then the second time I clicked on the link, it changed to a different file, which also did not download. Showed log file to Tom and he confirmed. Here are screenshots:
Here is the transaction: https://explorer.lbry.io/tx/794a4f62c5ba7b5531283e6259564338d1f45bae587f0123ea911c99059420cd