Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claim updates via publish require superfluous paramaters #1423

Closed
kauffj opened this issue Aug 30, 2018 · 2 comments
Closed

Claim updates via publish require superfluous paramaters #1423

kauffj opened this issue Aug 30, 2018 · 2 comments

Comments

@kauffj
Copy link
Member

kauffj commented Aug 30, 2018

When performing a claim update via publish, only the parameters changing (plus a value to identify the claim), should be required.

Currently, publish requires many parameters even if they are not changing. This results in extra engineering effort at the application level.

As an example, spee.ch currently requests data from the daemon simply to pass it back to the daemon. This is rather absurd.

@daovist
Copy link

daovist commented Aug 30, 2018

spee.ch could/should be storing this data when it saves a claim but it would be nice to avoid having to pass source data when updating existing claims, if possible

the code in question is still getting cleaned up but it gets used as follows:

publishParams['sources'] = fullClaim.claim.value.stream.source;

where publishParams is what will be sent in the request and fullClaim is the result of a resolve call to the daemon

@alyssaoc alyssaoc added needs: grooming Issue needs to be groomed before work can start needs: priority and removed needs: triage labels Sep 4, 2018
@alyssaoc alyssaoc removed the needs: grooming Issue needs to be groomed before work can start label Oct 4, 2018
@lyoshenka
Copy link
Member

closing in favor of #1823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants