Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync hash flip flop between Android/Desktop: wrap floats in int() to make sure deterministic accounts work #3000

Closed
tzarebczan opened this issue Jul 17, 2020 · 1 comment · Fixed by #3002
Closed

sync hash flip flop between Android/Desktop: wrap floats in int() to make sure deterministic accounts work #3000

tzarebczan opened this issue Jul 17, 2020 · 1 comment · Fixed by #3002
Labels
type: bug Existing functionality is wrong or broken

Comments

@tzarebczan
Copy link
Contributor

Finally was able to narrow down what's happening where we end up with 2 different sync hashes between the same wallet on Android and Desktop/lbry.tv. Looks like Android produces floats to 7 significant figures and Windows/Linux does 6.
@tzarebczan tzarebczan added the type: bug Existing functionality is wrong or broken label Jul 17, 2020
@tzarebczan
Copy link
Contributor Author

  • audit other places in the code with floats that could potentially cause issues

@tzarebczan tzarebczan changed the title sync hash flip flop between Android/Desktop: wrap floats in in() to make sure deterministic accounts work sync hash flip flop between Android/Desktop: wrap floats in int() to make sure deterministic accounts work Jul 17, 2020
@eukreign eukreign mentioned this issue Jul 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Existing functionality is wrong or broken
Projects
None yet
Milestone
No milestone
1 participant
@tzarebczan