Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unavailable download directory #1760

Merged
merged 1 commit into from Jan 11, 2019
Merged

Conversation

tzarebczan
Copy link
Contributor

@tzarebczan tzarebczan commented Jan 11, 2019

If an uploaded file had a directory that was removed, or if the old download directory doesn't exist, use the default.

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Why is this change necessary?

  • Bugfix
  • Feature
  • Breaking changes (bugfix or feature that introduces breaking changes)
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: N/A

What is the current behavior?

What is the new behavior?

Other information

If an uploaded file had a directory that was removed, or if the old download directory doesn't exist, use the default.
@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #1760 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1760      +/-   ##
==========================================
+ Coverage   63.82%   63.82%   +<.01%     
==========================================
  Files         150      150              
  Lines       13649    13652       +3     
==========================================
+ Hits         8711     8714       +3     
  Misses       4938     4938
Impacted Files Coverage Δ
lbrynet/extras/daemon/Daemon.py 56.76% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 248d1a1...254991d. Read the comment docs.

@eukreign eukreign added type: bug Existing functionality is wrong or broken area: files labels Jan 11, 2019
@eukreign eukreign merged commit 4c23add into master Jan 11, 2019
@eukreign eukreign deleted the unavailable_download_dir branch January 11, 2019 04:05
@tzarebczan
Copy link
Contributor Author

@jackrobison said he'd take a shot at this in his branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: files type: bug Existing functionality is wrong or broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants