Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .m4v video format type #1764

Merged
merged 1 commit into from Jan 15, 2019
Merged

add .m4v video format type #1764

merged 1 commit into from Jan 15, 2019

Conversation

tzarebczan
Copy link
Contributor

It's a container type very similar to mp4. Someone recently added one in the community top bids section.

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Why is this change necessary?

  • Bugfix
  • Feature
  • Breaking changes (bugfix or feature that introduces breaking changes)
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: N/A

What is the current behavior?

What is the new behavior?

Other information

It's a container type very similar to mp4. Someone recently added one in the community top bids section.
@codecov
Copy link

codecov bot commented Jan 14, 2019

Codecov Report

Merging #1764 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1764      +/-   ##
==========================================
+ Coverage   63.84%   63.98%   +0.13%     
==========================================
  Files         150      150              
  Lines       13647    13766     +119     
==========================================
+ Hits         8713     8808      +95     
- Misses       4934     4958      +24
Impacted Files Coverage Δ
lbrynet/extras/daemon/mime_types.py 100% <ø> (ø) ⬆️
lbrynet/extras/daemon/DaemonConsole.py 37.37% <0%> (-0.06%) ⬇️
lbrynet/schema/uri.py 96.72% <0%> (+1.06%) ⬆️
lbrynet/extras/daemon/analytics.py 64.15% <0%> (+6.05%) ⬆️
lbrynet/extras/looping_call_manager.py 75% <0%> (+12.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e74a5e8...e81cfa6. Read the comment docs.

@lbry-bot lbry-bot assigned jackrobison and unassigned tzarebczan Jan 15, 2019
@eukreign eukreign changed the title add m4v add .m4v video format type Jan 15, 2019
@eukreign eukreign added area: files type: new feature New functionality that does not exist yet labels Jan 15, 2019
@eukreign eukreign merged commit 7314494 into master Jan 15, 2019
@eukreign eukreign deleted the m4v branch January 15, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: files type: new feature New functionality that does not exist yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants