refactored configuration handling code and lbrynet cli
#1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eukreign
added
type: refactor
Codecov Report
@@ Coverage Diff @@
## master #1788 +/- ##
==========================================
+ Coverage 64.23% 65.51% +1.28%
==========================================
Files 151 150 -1
Lines 13565 13379 -186
==========================================
+ Hits 8713 8765 +52
+ Misses 4852 4614 -238
Continue to review full report at Codecov.
|
eukreign
force-pushed
the
cli_conf_refactor
branch
from
e8c93d9
to
2a77b0c
Compare
eukreign
changed the title
lbrynet clilbrynet cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backwards-incompatible: configuration settings
api_portandapi_hosthave been merged intoapi, this affects configuration files and usage via command line interface--apibackwards-incompatible:
download_directorysetting is nowdownload_dirto be consistent withdata_dirandwallet_dir.backwards-incompatible: all command line switches now use
-instead of_to delineate words, eg. you must now use--data-dirinstead of the old--data_dir, this is more consistent with almost every other command line interface known to manbackwards-incompatible: commands within groups, eg.
account_balance, require splitting the group and subcommand into separate command arguments (basically no_), eg. to get the balance you would do:lbrynet account balanceto get a list of all commands in theaccountgroup you would runlbrynet account.backwards-incompatible: previously deprecated commands have been permanently removed.