Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timestamp and rename depth to confirmations for output of commands resolve and file list #2067

Merged
merged 5 commits into from Apr 29, 2019

Conversation

shyba
Copy link
Member

@shyba shyba commented Apr 29, 2019

No description provided.

@shyba shyba requested a review from eukreign April 29, 2019 03:17
@shyba shyba added area: api type: new feature New functionality that does not exist yet labels Apr 29, 2019
@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #2067 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2067      +/-   ##
==========================================
- Coverage   78.61%   78.58%   -0.04%     
==========================================
  Files          94       94              
  Lines       10692    10700       +8     
==========================================
+ Hits         8406     8409       +3     
- Misses       2286     2291       +5
Impacted Files Coverage Δ
lbrynet/extras/daemon/Daemon.py 77.35% <ø> (+0.07%) ⬆️
lbrynet/wallet/resolve.py 88.4% <100%> (+0.17%) ⬆️
lbrynet/extras/daemon/json_response_encoder.py 92.7% <100%> (+0.31%) ⬆️
lbrynet/blob/writer.py 92.59% <0%> (-3.71%) ⬇️
lbrynet/blob/blob_file.py 91.85% <0%> (-0.91%) ⬇️
lbrynet/stream/reflector/server.py 78.51% <0%> (-0.83%) ⬇️
lbrynet/dht/protocol/iterative_find.py 84.58% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e483cb...e66b8df. Read the comment docs.

@eukreign eukreign changed the title add timestamp, rename depth to confirmations on resolve add timestamp and rename depth to confirmations for output of commands resolve and file list Apr 29, 2019
@eukreign eukreign added type: improvement Existing (or partially existing) functionality needs to be changed and removed type: new feature New functionality that does not exist yet labels Apr 29, 2019
@eukreign eukreign merged commit 7cf245a into master Apr 29, 2019
@eukreign eukreign deleted the fix_fields branch April 29, 2019 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: api type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants