Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start returning bytes for a range request at the requested starting position #2179

Merged
merged 1 commit into from May 24, 2019

Conversation

jackrobison
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #2179 into master will increase coverage by <.01%.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2179      +/-   ##
==========================================
+ Coverage   76.27%   76.27%   +<.01%     
==========================================
  Files          97       97              
  Lines       11118    11140      +22     
==========================================
+ Hits         8480     8497      +17     
- Misses       2638     2643       +5
Impacted Files Coverage Δ
lbrynet/extras/daemon/Daemon.py 75.8% <38.46%> (-0.4%) ⬇️
lbrynet/stream/managed_stream.py 91.85% <86.66%> (-0.37%) ⬇️
lbrynet/stream/reflector/server.py 79.33% <0%> (+0.82%) ⬆️
lbrynet/blob/blob_file.py 92.76% <0%> (+0.9%) ⬆️
lbrynet/blob/writer.py 96.29% <0%> (+3.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b922ea8...85d94d4. Read the comment docs.

@jackrobison jackrobison force-pushed the fix-range-request-start-offset branch 2 times, most recently from e199182 to c181feb Compare May 24, 2019 19:30
@jackrobison jackrobison force-pushed the fix-range-request-start-offset branch from c181feb to 85d94d4 Compare May 24, 2019 19:32
@jackrobison jackrobison merged commit 3ed72a2 into master May 24, 2019
@jackrobison jackrobison deleted the fix-range-request-start-offset branch May 24, 2019 20:46
@eukreign eukreign added area: blobs/files type: improvement Existing (or partially existing) functionality needs to be changed labels May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: blobs/files type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants