Skip to content
This repository has been archived by the owner on Sep 1, 2021. It is now read-only.

Should publish API require a claim name? #547

Closed
tzarebczan opened this issue Jul 31, 2018 · 3 comments
Closed

Should publish API require a claim name? #547

tzarebczan opened this issue Jul 31, 2018 · 3 comments
Assignees
Labels
type: discussion A conversation. No specific changes requested type: improvement Existing (or partially existing) functionality needs to be changed

Comments

@tzarebczan
Copy link
Contributor

If we are requiring a claim name on the spee.ch publish API, it should be clear that the name should contain some unique characters since we only support publishing to a single claim name (not sure how long we'll have this limitation, issue is filed on the daemon). This should also be the case if it's optional - someone won't know that until it fails to publish. Or maybe the solution is to tack on a -1/ -2 automatically?

@tzarebczan tzarebczan added type: improvement Existing (or partially existing) functionality needs to be changed type: discussion A conversation. No specific changes requested labels Jul 31, 2018
@bones7242
Copy link
Contributor

If a claim name is provided, we shouldn't change that claim while publishing because the request might be depending on getting that exact claim name back. I think giving them an error message is preferred. However, we could add a way for them to opt in to allowing spee.ch to change the claim name (perhaps an optional strict parameter which can be set to false ).

I do agree that the claim name should be optional though, and if not provided spee.ch generates a random hash for the name.

@alyssaoc
Copy link
Contributor

@tzarebczan Is this issue still valid?

@alyssaoc
Copy link
Contributor

closing, reopen if necessary

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: discussion A conversation. No specific changes requested type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

No branches or pull requests

5 participants