Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gui): flashing rendered rects (#180) #190

Merged
merged 1 commit into from Dec 23, 2019

Conversation

vbalyasnyy
Copy link
Contributor

@vbalyasnyy vbalyasnyy commented Dec 18, 2019

Signed-off-by: Vasilyy Balyasnyy v.balyasnyy@gmail.com

Fixes #180 .

Changes proposed in this pull request:

  • collecting rendered rectangle areas into list and remove that after duration time
  • render rectangles from list with linearly decreasing opacity value

@lc-soft


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

@vbalyasnyy
Copy link
Contributor Author

I'm adding LCUIDisplay_ShowRectBorder() call in LCUI_Init() to enable border flag to test this feature.

@coveralls
Copy link

coveralls commented Dec 18, 2019

Coverage Status

Coverage increased (+1.8%) to 68.537% when pulling 2dfcad4 on vbalyasnyy:develop into 460354c on lc-soft:develop.

Copy link
Owner

@lc-soft lc-soft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to adjust code style

src/display.c Outdated Show resolved Hide resolved
src/display.c Outdated Show resolved Hide resolved
src/display.c Outdated Show resolved Hide resolved
src/display.c Outdated Show resolved Hide resolved
@lc-soft
Copy link
Owner

lc-soft commented Dec 19, 2019

Please upload GIF screenshot.

@vbalyasnyy
Copy link
Contributor Author

Please upload GIF screenshot.

test_scaling_support
test_widget_opacity
test_widget_flex_layout
test_widget_inline_block_layout

Copy link
Owner

@lc-soft lc-soft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

src/display.c Outdated Show resolved Hide resolved
src/display.c Show resolved Hide resolved
src/display.c Outdated Show resolved Hide resolved
@vbalyasnyy
Copy link
Contributor Author

out

src/display.c Outdated Show resolved Hide resolved
src/display.c Outdated Show resolved Hide resolved
src/display.c Outdated Show resolved Hide resolved
Copy link
Owner

@lc-soft lc-soft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the last change, please correct the color.

src/display.c Outdated Show resolved Hide resolved
src/display.c Outdated Show resolved Hide resolved
Signed-off-by: Vasilyy Balyasnyy <v.balyasnyy@gmail.com>
@lc-soft lc-soft merged commit 52fe8c6 into lc-soft:develop Dec 23, 2019
lc-soft pushed a commit that referenced this pull request Jan 19, 2020
Signed-off-by: Vasilyy Balyasnyy <v.balyasnyy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve highlighting of repainted areas
3 participants