Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fractional delay input range #56

Closed
ebezzam opened this issue Oct 8, 2018 · 3 comments
Closed

Fractional delay input range #56

ebezzam opened this issue Oct 8, 2018 · 3 comments
Assignees
@fakufaku

Comments

@ebezzam
Copy link
Member

ebezzam commented Oct 8, 2018

pyroomacoustics/pyroomacoustics/utilities.py

Line 369 in 0d6025f

The delay in fraction of sample. Typically between 0 and 1.

Values within [-1,1] are also accepted. Can be edited in the next PR.
@fakufaku
Copy link
Collaborator

fakufaku commented Oct 8, 2018

Yes, I'll do a quick commit in the master branch if that's ok. Would the following be ok:

The delay in fraction of sample. Typically between -1 and 1.

?

@ebezzam
Copy link
Member Author

ebezzam commented Oct 8, 2018

Yeah thats perfect 👍

fakufaku added a commit that referenced this issue Oct 8, 2018
@fakufaku
Fixes docstring of pyroomacoustics.utilities.fractional_delay (issue #56
5e565e8 
)
@fakufaku
Copy link
Collaborator

fakufaku commented Oct 8, 2018

Fixed by 5e565e8

@fakufaku fakufaku closed this as completed Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fakufaku fakufaku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fakufaku @ebezzam